Additional coordinate stability considerations #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This complements forTrimmedWgsEnvelope to handle numerical instability or imprecision in a different case: tight bounds around sets of points that must fall into the resulting grid.
trevorgerhardt
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #897. The coordinate stability considerations addressed there also apply to building grids around sets of points, including destination opportunities and street vertices in transportation networks. Due to conversion back and forth from WGS84 to web Mercator, it is possible hat a grid made to be completely tight around the set of points may not actually contain some of the points.
This PR adds
WebMercatorExtents.forBufferedWgsEnvelopewhich complementsforTrimmedWgsEnvelopeto handle this case.This PR is a draft until the basic WGS-Mercator PR is merged, at which point this PR's base can be changed to dev.