Check if the bundle config exists, return 404 if missing #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansoncfit
approved these changes
Oct 5, 2024
| @@ -327,13 +327,17 @@ private Bundle getBundle (Request req, Response res) { | |||
| * and is considered the definitive source of truth. The entry in the database is a newer addition and has only | |||
| * been around since September 2024. | |||
| */ | |||
| private TransportNetworkConfig getBundleConfig (Request request, Response res) { | |||
| private TransportNetworkConfig getBundleConfig(Request request, Response res) { | |||
There was a problem hiding this comment.
Different style settings in IDE?
There was a problem hiding this comment.
I guess so? I did not intentionally change that. Similarly with the moving import, probably from "organize imports" on save.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When retrieving the config, return a clearer error if the file cannot be found so that can be handled individually.