-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add drupal-with-postgresql service template #2463
Conversation
Thanks, really nice idea to have a Drupal template, but please let me point out that the current directory structure used does not use the Drupal standards: See https://www.drupal.org/download > https://packagist.org/packages/drupal/recommended-project > https://github.com/drupal/recommended-project/blob/6b99c737444f91c14e4b5e9034fd6844415989ba/composer.json#L48
We should please stick to Drupal standards, when preparing such a service template. |
@JPustkuchen Could I ask you to elaborate on that? EDIT: |
@sandros94 I'm not using coolify yet. I can take a look at it, once I have the time. But to answer the question and unblock the issue here perhaps, I can tell the following: Drupal creates a certain folder structure when following the proposed composer installation (see link) and the coolify structure should follow that one. Update: Just saw your EDIT link. That's strange and I think it seems to be kind of inconsistency I can't understand (on the Drupal side). Some years ago Drupal used that So I posted a comment at docker-library/drupal#3 (comment) So the implementation here seems correct so far, based on the docker documentation, but maybe it's outdated upstream. |
Yeah, it is an inconsistency. Like for example if you want to seed a Drupal site you must first do it with another container or full build a custom image. Easily doable, but still not as intuitive as other projects.
Just saw you comment popping up as I was reading that issue. To me it does seem like an upstream refactoring is required. |
Hi @JPustkuchen I just followed drupal docker instructions while creating that template. Please see in volumes section https://hub.docker.com/_/drupal |
Okay, my assumption and confusion seems to have been wrong, as this comment points out: docker-library/drupal#3 (comment) I didn't see the link mapping this to the /html folder! Sorry for the confusion, so I think this is looking good, but as written above I didn't try it myself yet, so further feedback is welcome. |
Thank you for the PR! |
No description provided.