Make RTL and font-family properties work with iOS #188
Conversation
make RTL and font-family properties work with iOS.
There was a problem hiding this comment.
Thanks for this @Mahmoud-El-Sayed-92! It looks good, I'll test it on my emulator as soon as I can, and then release this.
If you're able to, could you please also update the README to remove the "Android only" text for these parameters? Documentation is important! Cheers.
| @@ -262,7 +262,8 @@ - (void)show { | |||
|
|
|||
| id textColor = _pendingOptions[@"textColor"]; | |||
| self.textColor = textColor ? [RCTConvert UIColor:textColor] : [UIColor whiteColor]; | |||
|
|
|||
| textLabel.font = [UIFont fontWithName:_pendingOptions[@"fontFamily"] size:15]; | |||
There was a problem hiding this comment.
Clarifying question: do you know that 15 is the default size? Why does this need to be explicitly set?
cooperka
changed the title
|
@cooperka Hi, whats the status of the PR ? if the author doesn't respond I can open another PR related to this. Our current project have an issue related the text font changing in iOS |
|
hi @LeXuanKhanh, yes, please open a new PR for this to address the above feedback. the author hasn't responded. thank you. |
Hi I have opened a new PR, can you please review it ? thanks |
make RTL and font-family properties work with iOS.