xt_coova: fix compile with kernel>=5.17 #564
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linux kernel 5.17 removed PDE_DATA, and replaced it with pde_data [0] [0]: torvalds/linux@359745d Signed-off-by: John Thomson <[email protected]>
|
@sevan can you look at it, please? Would be nice to see it merged as we would not carry patch in OpenWrt. |
sevan
reviewed
Jun 30, 2023
| #if LINUX_VERSION_CODE >= KERNEL_VERSION(3,10,0) | ||
| #if LINUX_VERSION_CODE >= KERNEL_VERSION(5,17,0) | ||
| st->table = pde_data(inode); | ||
| #elif LINUX_VERSION_CODE >= KERNEL_VERSION(3,10,0) |
There was a problem hiding this comment.
This needs an upper bound (before 5.17.0?)
There was a problem hiding this comment.
Thanks for taking a look sevan.
I thought the upper bound would be guarded by the else in #elif, so any kernel at or after 5.17 would not reach this?
Cheers
There was a problem hiding this comment.
it's more to protect against future edits, rather than compiling/parsing (at a glance to the human they both apply to 5.17, one just more so :) )
sevan
reviewed
Jun 30, 2023
| #if LINUX_VERSION_CODE >= KERNEL_VERSION(3,10,0) | ||
| #if LINUX_VERSION_CODE >= KERNEL_VERSION(5,17,0) | ||
| struct coova_table *t = pde_data(file_inode(file)); | ||
| #elif LINUX_VERSION_CODE >= KERNEL_VERSION(3,10,0) |
There was a problem hiding this comment.
Same here, needs an upper bound (before 5.17.0?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux kernel 5.17 removed PDE_DATA, and replaced it with pde_data 0
Signed-off-by: John Thomson [email protected]