tools: add linter rules

Signed-off-by: Doug Hellmann <[email protected]>

.gitignore

@@ -1,3 +1,4 @@
 *.swo
 *.swp
 .idea/*
+tools/bin

tools/.golangci.yml

@@ -0,0 +1,32 @@
+run:
+  timeout: "5m"
+
+linters:
+  disable-all: true
+  enable: [
+    "govet",
+    "goimports",
+    "gofmt",
+    "staticcheck",
+    "deadcode",
+    "dupl",
+    "errcheck",
+    "structcheck",
+    "unparam",
+    "unused",
+    "varcheck",
+  ]
+
+linters-settings:
+  goimports:
+    local-prefixes: "github.com/openshift/enhancements/tools"
+  govet:
+    check-shadowing: false
+
+issues:
+  max-issues-per-linter: 0
+  max-same-issues: 0
+  exclude-rules:
+   - linters:
+     - staticcheck
+     text: "SA1019:"

tools/Makefile

@@ -0,0 +1,13 @@
+ifeq (/,${HOME})
+GOLANGCI_LINT_CACHE=/tmp/golangci-lint-cache/
+else
+GOLANGCI_LINT_CACHE=${HOME}/.cache/golangci-lint
+endif
+
+# Run go lint against code
+.PHONY: lint
+lint: bin/golangci-lint
+	GOLANGCI_LINT_CACHE=$(GOLANGCI_LINT_CACHE) ./bin/golangci-lint run --exclude=G101
+
+bin/golangci-lint:
+	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b ./bin v1.31.0

tools/report/main.go

@@ -29,7 +29,7 @@ func fileExists(filename string) bool {
 }
 
 func handleError(msg string) {
-	fmt.Fprintf(os.Stderr, fmt.Sprintf("%s\n", msg))
+	fmt.Fprintf(os.Stderr, "%s\n", msg)
 	os.Exit(1)
 }
 

tools/stats/stats.go

@@ -45,7 +45,6 @@ func New(daysBack int, staleMonths int, orgName, repoName string, devMode bool,
 type Stats struct {
 	org          string
 	repo         string
-	minAge       int
 	earliestDate time.Time
 	staleDate    time.Time
 	devMode      bool