handle WIP prefixes in enhancement titles

fixes openshift#513 Signed-off-by: Doug Hellmann <[email protected]>
copejon · Nov 12, 2020 · 16d1dd5 · 16d1dd5
1 parent 8016677
commit 16d1dd5
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 4 deletions.
diff --git a/tools/enhancements/title.go b/tools/enhancements/title.go
@@ -2,11 +2,15 @@ package enhancements
 
 import "strings"
 
+var (
+	titlePrefixes = []string{"wip:", "[wip]", "enhancement:"}
+)
+
 func CleanTitle(title string) string {
-	// Sometimes we have a superfluous "enhancement:" prefix in
-	// the PR title
-	if strings.HasPrefix(strings.ToLower(title), "enhancement:") {
-		title = strings.TrimLeft(title[12:], " ")
+	for _, prefix := range titlePrefixes {
+		if strings.HasPrefix(strings.ToLower(title), prefix) {
+			title = strings.TrimLeft(title[len(prefix):], " ")
+		}
 	}
 	return title
 }
diff --git a/tools/enhancements/title_test.go b/tools/enhancements/title_test.go
@@ -32,6 +32,26 @@ func TestCleanTitle(t *testing.T) {
 			Input:    "Enhancement: Remove the prefix",
 			Expected: "Remove the prefix",
 		},
+		{
+			Scenario: "WIP:",
+			Input:    "WIP: Remove the prefix",
+			Expected: "Remove the prefix",
+		},
+		{
+			Scenario: "[wip]",
+			Input:    "[WIP] Remove the prefix",
+			Expected: "Remove the prefix",
+		},
+		{
+			Scenario: "combo",
+			Input:    "[WIP] enhancement: Remove the prefix",
+			Expected: "Remove the prefix",
+		},
+		{
+			Scenario: "combo-no-whitespace",
+			Input:    "[WIP]enhancement:Remove the prefix",
+			Expected: "Remove the prefix",
+		},
 	} {
 		t.Run(tc.Scenario, func(t *testing.T) {
 			actual := CleanTitle(tc.Input)