Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set MAC address via config file. #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rsteckler
Copy link

I'm running the container in Kubernetes. Every time the container is stopped and started, it gets a new MAC address, which breaks licensing. Kubernetes also doesn't allow one to set the mac address because the networking layer implementations don't support it.
This PR allows one to set the MAC_ADDRESS variable in the xeoma.conf. It's then set in the container before the xeoma server starts.

@skylord123
Copy link

I'm leaning towards getting rid of the config file for env variables. This would make things like upgrading easier (just change env variable instead of changing config file).

@rsteckler
Copy link
Author

Cool. I would still suggest using the method here to set the mac address supplied by the --mac-address environment variable. It doesn't require bridge networking and it's all handled within the container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants