Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few operators to binrat (refinement of rat by bigQ) #32

Merged
merged 7 commits into from
Jan 18, 2021

Conversation

proux01
Copy link
Collaborator

@proux01 proux01 commented Jan 8, 2021

No description provided.

@proux01
Copy link
Collaborator Author

proux01 commented Jan 18, 2021

CI green, @CohenCyril would you allow me to merge this, do a release and the OPAM package or would you prefer to have a look first / do it yourself?

@CohenCyril CohenCyril merged commit 5516a3a into coq-community:master Jan 18, 2021
@CohenCyril
Copy link
Collaborator

@proux01 sure, you can go ahead.

@proux01 proux01 deleted the binrat-div branch January 18, 2021 17:12
@proux01
Copy link
Collaborator Author

proux01 commented Jan 18, 2021

  • I would be in favour of a transition to a meta.yml generated meta data.

good point, done

I'll be happy to try it once the required release of multinomials will have happened : math-comp/multinomials#38

@proux01
Copy link
Collaborator Author

proux01 commented Jan 19, 2021

So I just tried it, it's nice, a few minor comments:

  • I had to update from OPAM 2.0.3 to 2.0.5, an opam version check would be great, but definitely a detail
  • I had to git config --add github.user <user> otherwise the call to git config makes the whole script fail (on line 59, without error message, whatever the options provided)
  • I would love an option to use an already existing clone of coq-opam-archive, the clone takes both bandwidth and time

@CohenCyril
Copy link
Collaborator

CohenCyril commented Jan 19, 2021

Thank you very much for trying. Could you tell me what failed with opam 2.0.3?

@proux01
Copy link
Collaborator Author

proux01 commented Jan 19, 2021

The lint option check-upstream did not exist (it may exist in 2.0.4, haven't tried).

@CohenCyril
Copy link
Collaborator

  • I would love an option to use an already existing clone of coq-opam-archive, the clone takes both bandwidth and time

I will definitely provide this option. Note that you can also use --depth n (start with n=1 and increase if it does not work) to do a shallow clone (it may fail because sometimes pushes of branches from clones that are too shallow are rejected by github)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants