-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Towards a more uniform API for declare.ml (part declaring mutual statements) #18795
Merged
coqbot-app
merged 12 commits into
coq:master
from
herbelin:master+uniform-API-declare.ml
May 28, 2024
Merged
Towards a more uniform API for declare.ml (part declaring mutual statements) #18795
coqbot-app
merged 12 commits into
coq:master
from
herbelin:master+uniform-API-declare.ml
May 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herbelin
added
kind: cleanup
Code removal, deprecation, refactorings, etc.
needs: merge of dependency
This PR depends on another PR being merged first.
part: vernac
High level command interpretation.
labels
Mar 14, 2024
coqbot-app
bot
added
the
needs: rebase
Should be rebased on the latest master to solve conflicts or have a newer CI run.
label
Mar 14, 2024
herbelin
force-pushed
the
master+uniform-API-declare.ml
branch
from
March 14, 2024 13:51
23ea0f6
to
aa23b15
Compare
coqbot-app
bot
added
needs: full CI
The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI.
and removed
needs: rebase
Should be rebased on the latest master to solve conflicts or have a newer CI run.
labels
Mar 14, 2024
herbelin
added
the
request: full CI
Use this label when you want your next push to trigger a full CI.
label
Mar 15, 2024
herbelin
force-pushed
the
master+uniform-API-declare.ml
branch
from
March 15, 2024 08:59
aa23b15
to
036a797
Compare
coqbot-app
bot
removed
request: full CI
Use this label when you want your next push to trigger a full CI.
needs: full CI
The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI.
labels
Mar 15, 2024
github-actions
bot
added
the
needs: rebase
Should be rebased on the latest master to solve conflicts or have a newer CI run.
label
Mar 21, 2024
herbelin
force-pushed
the
master+uniform-API-declare.ml
branch
from
March 23, 2024 08:56
036a797
to
510069e
Compare
coqbot-app
bot
added
needs: full CI
The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI.
and removed
needs: rebase
Should be rebased on the latest master to solve conflicts or have a newer CI run.
labels
Mar 23, 2024
github-actions
bot
added
the
needs: rebase
Should be rebased on the latest master to solve conflicts or have a newer CI run.
label
Apr 3, 2024
herbelin
force-pushed
the
master+uniform-API-declare.ml
branch
from
April 6, 2024 09:21
510069e
to
658fb69
Compare
coqbot-app
bot
removed
the
needs: rebase
Should be rebased on the latest master to solve conflicts or have a newer CI run.
label
Apr 6, 2024
herbelin
added
the
request: full CI
Use this label when you want your next push to trigger a full CI.
label
Apr 12, 2024
herbelin
force-pushed
the
master+uniform-API-declare.ml
branch
from
April 12, 2024 17:27
658fb69
to
5c8cd90
Compare
coqbot-app
bot
removed
request: full CI
Use this label when you want your next push to trigger a full CI.
needs: full CI
The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI.
labels
Apr 12, 2024
herbelin
added
the
request: full CI
Use this label when you want your next push to trigger a full CI.
label
Apr 19, 2024
coqbot-app
bot
added
the
needs: full CI
The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI.
label
May 21, 2024
Sounds good @herbelin , I have no strong opinion, if we find a better name we can change it later of course. |
Adopting the plural form then. |
github-actions
bot
added
the
needs: rebase
Should be rebased on the latest master to solve conflicts or have a newer CI run.
label
May 24, 2024
herbelin
added
the
request: full CI
Use this label when you want your next push to trigger a full CI.
label
May 25, 2024
herbelin
force-pushed
the
master+uniform-API-declare.ml
branch
from
May 26, 2024 07:48
317a52e
to
3c84501
Compare
coqbot-app
bot
removed
needs: rebase
Should be rebased on the latest master to solve conflicts or have a newer CI run.
request: full CI
Use this label when you want your next push to trigger a full CI.
needs: full CI
The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI.
labels
May 26, 2024
This was referenced May 26, 2024
ppedrot
approved these changes
May 28, 2024
@coqbot merge now |
@ppedrot: Please take care of the following overlays:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind: cleanup
Code removal, deprecation, refactorings, etc.
part: vernac
High level command interpretation.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to present some uniformity in the API of
declare.ml
so that it is clearer to compare the different functions. It should not change the semantics.Depends on
#18742 and#18743 (merged).It has an impact on the exact API though with the following API changes:
function renamings
declare_mutually_recursive
->declare_mutual_definition
(+ labelrec_declaration
->bodies
), consistently withdeclare_definition
start_with_initialization
->start_definition
start_mutual_with_initialization
->start_mutual_definition
(+ labelinit_term
->bodies
)other labels renaming
add_definition
:term
->body
, andopaque
made mandatoryadd_mutual_definitions
: argument (cinfo,bodies,obls) -> labelscinfo
andbodies
+ obls kept as unnamed argumentTODO, pending question: mutual_definition or mutual_definitions?
Overlays (due to opaque made mandatory)