added option to verify server's cert fingerprint #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corecode
requested changes
Dec 28, 2019
crypto.c
Outdated
| fingerprint_len); | ||
| return 1; | ||
| } | ||
| for(unsigned int i=0; i<SHA256_DIGEST_LENGTH; i++) { |
crypto.c
Outdated
| if(!X509_digest(cert, EVP_sha256(), fingerprint, &fingerprint_len)) { | ||
| syslog(LOG_WARNING, "failed to load fingerprint of server's certicate: %s", | ||
| ssl_errstr()); | ||
| return 1; |
dma.8
Outdated
| @@ -226,6 +226,8 @@ Uncomment if you want TLS/SSL secured transfer. | |||
| Uncomment if you want to use STARTTLS. | |||
| Only useful together with | |||
| .Sq SECURETRANS . | |||
| .It Ic FINGERPRINT Xo | |||
| Optionally verify SHA256 fingerprint of smarthost's certificate. | |||
There was a problem hiding this comment.
How about: "Pin the server certificate by specifying its SHA256 fingerprint. Only makes sense if you use a smarthost."
dma.conf
Outdated
| @@ -25,6 +25,9 @@ | |||
| # SECURETRANSFER) | |||
| #STARTTLS | |||
|
|
|||
| # Optionally verify SHA256 fingerprint of smarthost's certificate. | |||
crypto.c
Outdated
| @@ -78,6 +78,30 @@ init_cert_file(SSL_CTX *ctx, const char *path) | |||
| return (0); | |||
| } | |||
|
|
|||
| unsigned int verify_server_fingerprint(const X509 *cert) | |||
There was a problem hiding this comment.
int
verify_server_fingerprint(...)
conf.c
Outdated
| if (fingerprint == NULL) { | ||
| errlogx(EX_CONFIG, "fingerprint allocation failed"); | ||
| } | ||
| for (unsigned int i=0; i<SHA256_DIGEST_LENGTH; i++) { |
fphammerle
added a commit
to fphammerle/dma
that referenced
this pull request
Dec 29, 2019
fphammerle
force-pushed
the
check-server-fingerprint
branch
from
8f1204a
to
2865b20
Compare
|
Thanks for the quick response and review I applied your suggestions |
corecode
approved these changes
Dec 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10