Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gems, rails 7.0.8, puma 6.4, latest rubocops #2055

Merged
merged 5 commits into from
Oct 11, 2023

Conversation

andrewfader
Copy link
Collaborator

@andrewfader andrewfader commented Sep 10, 2023

@david-a-wheeler Updates to latest rails (7.0.8), puma 6.4, latest rubocops, and other gems

@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7dea484) 98.03% compared to head (520b109) 98.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2055   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files          53       53           
  Lines        2090     2090           
=======================================
  Hits         2049     2049           
  Misses         41       41           
Files Coverage Δ
app/controllers/projects_controller.rb 99.69% <100.00%> (ø)
app/lib/blank_detective.rb 100.00% <ø> (ø)
app/lib/chief.rb 100.00% <100.00%> (ø)
app/mailers/report_mailer.rb 100.00% <100.00%> (ø)
app/models/project.rb 100.00% <100.00%> (ø)
app/models/project_stat.rb 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewfader andrewfader changed the title update gems update gems, rails 7.0.8, puma 6.4 Oct 11, 2023
@andrewfader andrewfader added ruby Pull requests that update Ruby code dependencies Pull requests that update a dependency file labels Oct 11, 2023
@andrewfader
Copy link
Collaborator Author

spelling error Error: ./app/lib/subdir_file_contents_detective.rb:17: secur ==> secure is not a real issue

@andrewfader andrewfader changed the title update gems, rails 7.0.8, puma 6.4 update gems, rails 7.0.8, puma 6.4, latest rubocops Oct 11, 2023
Signed-off-by: Andrew Fader <[email protected]>
Signed-off-by: Andrew Fader <[email protected]>
Signed-off-by: Andrew Fader <[email protected]>
Signed-off-by: Andrew Fader <[email protected]>
Signed-off-by: Andrew Fader <[email protected]>
@david-a-wheeler
Copy link
Collaborator

Looks good! Thanks!

@david-a-wheeler david-a-wheeler merged commit a51ed45 into main Oct 11, 2023
6 checks passed
@andrewfader andrewfader deleted the update-gems-20230910 branch October 11, 2023 19:35
@david-a-wheeler david-a-wheeler mentioned this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants