-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start of generating markdown checklist #2104
Conversation
This isn't complete, but starts down the path of creating a checklist in GitHub Flavored Markdown. Signed-off-by: David A. Wheeler <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2104 +/- ##
=======================================
Coverage 98.03% 98.04%
=======================================
Files 53 53
Lines 2090 2092 +2
=======================================
+ Hits 2049 2051 +2
Misses 41 41 ☔ View full report in Codecov by Sentry. |
This first version only shows the criterion identifier; it doesn't show the full text of the criteria (or its details). That obviously needs to be fixed (and we want to ensure it uses the correct language, e.g., show French if that's the locale chosen). This currently serves the result as MIME type This isn't done, but I wanted to show the probable direction. |
This also needs to embed URLs for the badge entry, the repo URL, and the homepage URL. That way, people who see the markdown can quickly get other information. It should also embed the "generated date". |
It turns out that GitHub Flavored Markdown on GitHub does support the HTML5 "details" tag. Unfortunately the default formatting forces a newline when the details start. That means that the details "summary" tag by default looks terrible. Trying contain the Markdown in the "summary" disables the markdown processing inside it. However, this isn't too bad, if we want details:
|
Signed-off-by: David A. Wheeler <[email protected]>
I have a first cut. Here's what its results look like: BadgeApp
|
It's a pain to calculate "complete" for each upper level, and it'll be a pain for humans to compute them too. I think the checkmarks for headings are too confusing, too. I suggest we just keep the header names, but not make them their own checkmarks. |
Signed-off-by: David A. Wheeler <[email protected]>
When I remove checkboxes for headings, we end up with this: BadgeApp
|
If this isn't marked as html_safe, some of the descriptions look bad because it shows the HTML code instead of its intent. Signed-off-by: David A. Wheeler <[email protected]>
Revised, no longer using HTML escaping for descriptions (which are known safe): BadgeApp
|
Include the current time, so people who use the checklist as a workflow will know when the checklist was generated. Signed-off-by: David A. Wheeler <[email protected]>
This isn't complete, but starts down the path of creating a checklist in GitHub Flavored Markdown.