Change user search to be OR instead of AND #2190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new admin capability for user search is primarily for GDPR requests (and similar). The previous implementation, if provided with both name and email, returned only results that met BOTH criteria (an "AND"). However, for GPDR requests, it's far more convenient to reply all users matching EITHER criteria (an "OR"). We want to ensure that we identify all possible records, even those that only partly match. This changes user search from "AND" to "OR", to better support GDPR requests and similar. Signed-off-by: David A. Wheeler <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2190 +/- ##
=======================================
Coverage 98.08% 98.09%
=======================================
Files 55 55
Lines 2139 2147 +8
=======================================
+ Hits 2098 2106 +8
Misses 41 41 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new admin capability for user search is primarily for GDPR requests (and similar). The previous implementation, if provided with both name and email, returned only results that met BOTH criteria (an "AND").
However, for GPDR requests, it's far more convenient to reply all users matching EITHER criteria (an "OR"). We want to ensure that we identify all possible records, even those that only partly match.
This changes user search from "AND" to "OR", to better support GDPR requests and similar.