Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

providers: add support for scaleway #982

Merged
merged 1 commit into from
Sep 21, 2023
Merged

providers: add support for scaleway #982

merged 1 commit into from
Sep 21, 2023

Conversation

xinau
Copy link

@xinau xinau commented Aug 8, 2023

This change adds support for Scaleway as a platform by adding a new provider. The new ScalewayProvider has the capability to

  • Get attributes
  • Check-in after boot
  • Retrieve SSH keys

prestist
prestist reviewed Aug 10, 2023
View reviewed changes
Copy link
Contributor

@prestist prestist left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow thank you so much for working on this! Great work.

Also make sure to add a line in the afterburn release notes doc

Additionally please go ahead and file a Platform request to ensure all parts are covered.
https://github.com/coreos/fedora-coreos-tracker/issues/new/choose

docs/usage/attributes.md Show resolved Hide resolved
@xinau
Copy link
Author

xinau commented Aug 28, 2023

@prestist Thanks for the review. Sorry for the delayed response, been on vacation :). Going to resolve you're comments later today/tomorrow.

@miabbott
Copy link
Member

Additionally please go ahead and file a Platform request to ensure all parts are covered.
https://github.com/coreos/fedora-coreos-tracker/issues/new/choose

Found an existing platform request for Scaleway - coreos/fedora-coreos-tracker#866

@xinau
Copy link
Author

xinau commented Aug 30, 2023

@prestist Could you give this another review? Anything else that needs to be adjusted?
@miabbott Thanks for doing the due diligence of searching for the open platform request.

@xinau xinau force-pushed the xinau/add-support-for-scaleway branch from 7179fe3 to a674dea Compare August 30, 2023 06:41
@prestist
Copy link
Contributor

prestist commented Sep 6, 2023

@xinau Sorry for the silence; taking a look today and will get back to you if I have any other questions :)

prestist
prestist reviewed Sep 6, 2023
View reviewed changes
Copy link
Contributor

@prestist prestist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright everything looks great! thank you :)

The only nit that I would want fixed is if you could join the 3 commits into 1?

Thank you!

@xinau
Copy link
Author

xinau commented Sep 13, 2023

Going to join the commits this evening. Thanks for the assistance :)

providers: add support for scaleway
b5215c2 
This change adds support for [Scaleway](https://scaleway.com) as a
platform by adding a new provider. The new `ScalewayProvider` has the
capability to

* Get attributes
* Check-in after boot
* Retrive SSH keys

Signed-off-by: Felix Ehrenpfort <[email protected]>
@xinau xinau force-pushed the xinau/add-support-for-scaleway branch from a674dea to b5215c2 Compare September 16, 2023 22:39
@xinau
Copy link
Author

xinau commented Sep 16, 2023 •
edited
Loading

@prestist I've rebased the branch and put the 3 commits into a single one. Sorry it took a bit longer than expected.

prestist
prestist approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@prestist prestist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you again for being so diligent on this and adding support for a new provider!

@prestist prestist merged commit ebd3186 into coreos:main Sep 21, 2023
@xinau
Copy link
Author

xinau commented Sep 21, 2023

@prestist Thanks for your support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestist prestist prestist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xinau @miabbott @prestist