cmd-build: Fix use of bash arrays

The docs and syntax for these are confusing...need to rewrite this in "not bash".
coreos · Feb 6, 2019 · cfc9e0c · cfc9e0c
1 parent 4d4cdaf
commit cfc9e0c
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/cmd-build b/src/cmd-build
@@ -58,12 +58,15 @@ while true; do
 done
 
 declare -a IMAGE_TYPES
-for itype in "$@"; do
-    IMAGE_TYPES[]="$itype"
+IMAGE_TYPES=()
+# shellcheck disable=SC2068
+for itype in $@; do
+    IMAGE_TYPES+=("$itype")
 done
-if [ "${IMAGE_TYPES[*]}" == 0 ]; then
+if [ "${#IMAGE_TYPES[@]}" == 0 ]; then
     IMAGE_TYPES=(qemu)
 fi
+echo "Image types: ${IMAGE_TYPES[*]}"
 
 export LIBGUESTFS_BACKEND=direct