Skip to content

Commit

Permalink
osbuild: go back to setting metadata_csum_seed=true
Browse files Browse the repository at this point in the history
Here we just unconditionally set it because otherwise changing
the filesystem while it is mounted doesn't work and we get errors
like this during startup:

```
[    4.155947] ignition-ostree-firstboot-uuid[918]: /dev/disk/by-label/boot is in use.
```

Anyways, we are going to delete the fallback code there anyway
coreos/fedora-coreos-config#3008
so it's required to be set so let's set it here and then we can
drop this once RHEL has caught up.
  • Loading branch information
dustymabe committed May 22, 2024
1 parent 3a1e293 commit f9f9c5b
Show file tree
Hide file tree
Showing 4 changed files with 40 additions and 0 deletions.
10 changes: 10 additions & 0 deletions src/osbuild-manifests/coreos.osbuild.aarch64.mpp.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,11 @@ pipelines:
mpp-format-string: '{boot_fs_uuid}'
label:
mpp-format-string: '{boot_fs_label}'
# Set manually the metadata_csum_seed ext4 option otherwise changing the
# filesystem UUID while it's mounted doesn't work. Can remove this when
# metadata_csum_seed is default in RHEL, which can be checked by looking
# in /etc/mke2fs.conf.
metadata_csum_seed: true
- type: org.osbuild.mkfs.xfs
devices:
device:
Expand Down Expand Up @@ -449,6 +454,11 @@ pipelines:
mpp-format-string: '{boot_fs_uuid}'
label:
mpp-format-string: '{boot_fs_label}'
# Set manually the metadata_csum_seed ext4 option otherwise changing the
# filesystem UUID while it's mounted doesn't work. Can remove this when
# metadata_csum_seed is default in RHEL, which can be checked by looking
# in /etc/mke2fs.conf.
metadata_csum_seed: true
- type: org.osbuild.mkfs.xfs
devices:
device:
Expand Down
10 changes: 10 additions & 0 deletions src/osbuild-manifests/coreos.osbuild.ppc64le.mpp.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,11 @@ pipelines:
mpp-format-string: '{boot_fs_uuid}'
label:
mpp-format-string: '{boot_fs_label}'
# Set manually the metadata_csum_seed ext4 option otherwise changing the
# filesystem UUID while it's mounted doesn't work. Can remove this when
# metadata_csum_seed is default in RHEL, which can be checked by looking
# in /etc/mke2fs.conf.
metadata_csum_seed: true
- type: org.osbuild.mkfs.xfs
devices:
device:
Expand Down Expand Up @@ -419,6 +424,11 @@ pipelines:
mpp-format-string: '{boot_fs_uuid}'
label:
mpp-format-string: '{boot_fs_label}'
# Set manually the metadata_csum_seed ext4 option otherwise changing the
# filesystem UUID while it's mounted doesn't work. Can remove this when
# metadata_csum_seed is default in RHEL, which can be checked by looking
# in /etc/mke2fs.conf.
metadata_csum_seed: true
- type: org.osbuild.mkfs.xfs
devices:
device:
Expand Down
10 changes: 10 additions & 0 deletions src/osbuild-manifests/coreos.osbuild.s390x.mpp.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,11 @@ pipelines:
mpp-format-string: '{boot_fs_uuid}'
label:
mpp-format-string: '{boot_fs_label}'
# Set manually the metadata_csum_seed ext4 option otherwise changing the
# filesystem UUID while it's mounted doesn't work. Can remove this when
# metadata_csum_seed is default in RHEL, which can be checked by looking
# in /etc/mke2fs.conf.
metadata_csum_seed: true
- type: org.osbuild.mkfs.xfs
devices:
device:
Expand Down Expand Up @@ -389,6 +394,11 @@ pipelines:
mpp-format-string: '{boot_fs_uuid}'
label:
mpp-format-string: '{boot_fs_label}'
# Set manually the metadata_csum_seed ext4 option otherwise changing the
# filesystem UUID while it's mounted doesn't work. Can remove this when
# metadata_csum_seed is default in RHEL, which can be checked by looking
# in /etc/mke2fs.conf.
metadata_csum_seed: true
- type: org.osbuild.mkfs.xfs
devices:
device:
Expand Down
10 changes: 10 additions & 0 deletions src/osbuild-manifests/coreos.osbuild.x86_64.mpp.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,11 @@ pipelines:
mpp-format-string: '{boot_fs_uuid}'
label:
mpp-format-string: '{boot_fs_label}'
# Set manually the metadata_csum_seed ext4 option otherwise changing the
# filesystem UUID while it's mounted doesn't work. Can remove this when
# metadata_csum_seed is default in RHEL, which can be checked by looking
# in /etc/mke2fs.conf.
metadata_csum_seed: true
- type: org.osbuild.mkfs.xfs
devices:
device:
Expand Down Expand Up @@ -453,6 +458,11 @@ pipelines:
mpp-format-string: '{boot_fs_uuid}'
label:
mpp-format-string: '{boot_fs_label}'
# Set manually the metadata_csum_seed ext4 option otherwise changing the
# filesystem UUID while it's mounted doesn't work. Can remove this when
# metadata_csum_seed is default in RHEL, which can be checked by looking
# in /etc/mke2fs.conf.
metadata_csum_seed: true
- type: org.osbuild.mkfs.xfs
devices:
device:
Expand Down

0 comments on commit f9f9c5b

Please sign in to comment.