Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmdlib: use lowercase query tags for dnf repoquery --qf #3427

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Apr 14, 2023

Uppercase query tags broke in dnf v4.15.0. There is an upstream PR[1] to track restoring support for them, but since the canonical tag names are lowercase, switch to that.

Fixes coreos/rpm-ostree#4368.

Uppercase query tags broke in dnf v4.15.0. There is an upstream PR[[1]]
to track restoring support for them, but since the canonical tag names
are lowercase, switch to that.

Fixes coreos/rpm-ostree#4368.

[1]: rpm-software-management/dnf#1922
@cgwalters
Copy link
Member

Ohhhhh that makes sense, we were ending up with that data literally in the lockfile. Got it.

@cgwalters cgwalters enabled auto-merge (rebase) April 14, 2023 19:19
@dustymabe
Copy link
Member

What made you hit this problem?

@cgwalters
Copy link
Member

What made you hit this problem?

See this link in the commit message:

Fixes coreos/rpm-ostree#4368.

@dustymabe
Copy link
Member

What made you hit this problem?

See this link in the commit message:

Fixes coreos/rpm-ostree#4368.

Ahh sorry. Missed that.

That does still make me wonder. You said in that issue:

AFAICS, none of the usual suspects of rpm, libsolv or librepo have been updated in F37 recently.

@jlebon
Copy link
Member Author

jlebon commented Apr 14, 2023

Yeah, the bug was introduced in dnf via this Bodhi update.

@cgwalters
Copy link
Member

AFAICS, none of the usual suspects of rpm, libsolv or librepo have been updated in F37 recently.

Yes, but I was thinking the bug was in rpm-ostree's address space. I didn't get to the point of realizing that the broken data was in the lockfile, and so I hadn't considered dnf - I didn't think to look at the bodhi updates for it. (I also forgot we wrote the lockfile here manually via dnf...)

And now looking at https://bodhi.fedoraproject.org/updates/FEDORA-2023-79922004f7 I see we weren't the only things broken by this.

@jlebon
Copy link
Member Author

jlebon commented Apr 17, 2023

Prow failures seem unrelated. (And hmm, seems like not all the kola results are getting archived? Filed #3432.)

/override ci/prow/rhcos

@openshift-ci
Copy link

openshift-ci bot commented Apr 17, 2023

@jlebon: Overrode contexts on behalf of jlebon: ci/prow/rhcos

In response to this:

Prow failures seem unrelated. (And hmm, seems like not all the kola results are getting archived? Filed #3432.)

/override ci/prow/rhcos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters cgwalters merged commit 7c819e4 into coreos:main Apr 17, 2023
@jlebon jlebon deleted the pr/dnf-query-tags branch April 22, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI is not testing built binaries
3 participants