platform/metal: don't set console key on s390x
#3439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
force-pushed
the
pr/s390x-testiso-console
branch
from
417ef71 to
91fe69a
Compare
Otherwise, coreos-installer will look for a GRUB config even though one does not exist.[[1]] Anyway, it seems like we don't need to change anything on s390x since looking at the testiso logs, one can see that `console.txt` does contain all the logs already. So don't even bother setting a karg instead. Follow-up to 694f96f ("platform/metal: set serial console in PXE and ISO tests"). [1]: coreos/coreos-installer#1171
jlebon
force-pushed
the
pr/s390x-testiso-console
branch
from
91fe69a to
abd4336
Compare
|
Prow doesn't test this and this is blocking pipelines, so |
|
@jlebon: Overrode contexts on behalf of jlebon: ci/prow/rhcos In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, coreos-installer will look for a GRUB config even though
one does not exist.[1] Anyway, it seems like we don't need to change
anything on s390x since looking at the testiso logs, one can see that
console.txtdoes contain all the logs already. So don't even bothersetting a karg instead.
Follow-up to 694f96f ("platform/metal: set serial console in PXE and
ISO tests").