Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support cosa build on RISCV64 #3459

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Support cosa build on RISCV64 #3459

merged 1 commit into from
Sep 11, 2023

Conversation

nirousseau
Copy link

@nirousseau nirousseau commented May 8, 2023 •
edited
Loading

Feature Request

Issue

#3460

Motivation and Context

Enable RISCV64 architecture in dependencies in order to build coreos on RISCV64 CPU.

How to test this PR?

Compile and run the test suite against a native RISCV64 board. Luckily, I have a board provided by RiscV International for qualification.

@nirousseau nirousseau mentioned this pull request May 8, 2023
Open
@openshift-ci
Copy link

openshift-ci bot commented May 8, 2023

Hi @nirousseau. Thanks for your PR.

I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters
Copy link
Member

/ok-to-test
This looks nice and simple and low risk to merge to me.

cgwalters
cgwalters previously approved these changes Sep 7, 2023
View reviewed changes
jlebon
jlebon reviewed Sep 7, 2023
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this too, though can it be made more clear that we're still far from full support? IIUC, this is just enough to get cosa build to work, right? (The PR description mentions running testsuites, though I'm not sure how that'd work without teaching kola about it too.) E.g. maybe let's retitle the commit message something like:

Support cosa build on RISCV64

src/cmdlib.sh Show resolved Hide resolved
@nirousseau
Copy link
Author

I'm OK with this too, though can it be made more clear that we're still far from full support? IIUC, this is just enough to get cosa build to work, right? (The PR description mentions running testsuites, though I'm not sure how that'd work without teaching kola about it too.) E.g. maybe let's retitle the commit message something like:

Support cosa build on RISCV64

yes the idea is to unblock this build step

@warhawk3407 @jlebon
Support cosa build on RISCV64
91a1fe8 
This is all we need to unblock `cosa build` on RISCV64. Obviously, this
is far from complete support for the platform, but it allows developers
to experiment with cosa on that arch.

Related: coreos#3460
@jlebon jlebon changed the title Draft: Add RISCV64 as supported architecture. Support cosa build on RISCV64 Sep 11, 2023
jlebon
jlebon approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I tweaked the commit message and squashed the second commit into the first.

@jlebon jlebon enabled auto-merge (rebase) September 11, 2023 23:04
@jlebon jlebon merged commit cd3937f into coreos:main Sep 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlebon jlebon jlebon approved these changes

@cgwalters cgwalters cgwalters left review comments

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nirousseau @cgwalters @jlebon @warhawk3407