[rhcos-4.14] live-iso: Write kernel (and hmac) to /boot too #3626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful in order to make the dracut FIPS module work. For ostree, we put the kernel stuff in `/boot/ostree` in order to namespace things. But non-ostree systems tend to use `/boot` directly, and that's what the dracut module is hardcoded to do. Now we did add some logic in the dracut module which scrapes the grub-injected `BOOT_IMAGE`, except this doesn't work for how we generate the CoreOS Live ISO today because the filenames of the kernel don't include versions etc. In the case of the Live ISO though we don't really need to "ostree namespace" things, so just hardlink the kernel binary and the hmac file into the traditional places in `/boot`. We *could* not do this, and do it in our dracut module in the initramfs in fips mode only for the Live ISO, but that'd be way more ugly. xref https://issues.redhat.com/browse/OCPBUGS-15843 (cherry picked from commit 86943ca)
jlebon
changed the title
jlebon
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problem that we backported the FIPS test but not the enablement here.
This is useful in order to make the dracut FIPS module work. For ostree, we put the kernel stuff in
/boot/ostreein order to namespace things. But non-ostree systems tend to use/bootdirectly, and that's what the dracut module is hardcoded to do.Now we did add some logic in the dracut module which scrapes the grub-injected
BOOT_IMAGE, except this doesn't work for how we generate the CoreOS Live ISO today because the filenames of the kernel don't include versions etc.In the case of the Live ISO though we don't really need to "ostree namespace" things, so just hardlink the kernel binary and the hmac file into the traditional places in
/boot.We could not do this, and do it in our dracut module in the initramfs in fips mode only for the Live ISO, but that'd be way more ugly.
xref https://issues.redhat.com/browse/OCPBUGS-15843
(cherry picked from commit 86943ca)