Drop composefs setting #3732
Closed
Drop composefs setting #3732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since ostreedev/ostree#3165 this can be configured in the ostree commit itself.
jlebon
reviewed
Feb 21, 2024
Comment on lines
-338
to
-345
| # See https://github.com/coreos/coreos-assembler/pull/1379 - we want the local | ||
| # dev case to explicitly fetch updates when they want them, plus CI pipelines | ||
| # generally want to react to "changed or not" with a separate `fetch`. | ||
| # The fetched-stamp is new, in order to not break existing workdirs we assume | ||
| # a fetch was done if a successful build was done. | ||
| if [ ! -f "${workdir}"/builds/builds.json ] && [ ! -f "${fetch_stamp}" ] ; then | ||
| fatal "Must fetch before building" | ||
| fi |
|
As I commented in ostreedev/ostree#3165, we still rely on the global setting to change the default of use_fsverity from NO to MAYBE. If this is dropped, then composefs with fs-verity will not work. And really, this needs to be a global options, because objects are shared between images, so even if the image being pulled doesn't use composefs, another may reuse its objects and do use composefs. |
|
Closing based on #3732 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ostreedev/ostree#3165 this can be configured in the ostree commit itself.