osbuild: set sysroot.bootprefix true in OSTree config #3744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a second round of f5677a3 (reverted in db7bf08). Now that coreos-installer in rawhide has coreos/coreos-installer#1422 we can set sysroot.bootprefix to true again. We can't do it in the non-OSBuild configs because not all streams have the new coreos-installer yet. Here is the comment from the original commit: This setting will make it so that BLS config entries get prepended with /boot. OSTree already places a boot -> . symlink in the root of the boot filesystem prepending with /boot will always just work. For context see osbuild/osbuild#1566 (comment) This also allows for dropping one of the upstream OSBuild zipl stage patches.
jlebon
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second round of f5677a3 (reverted in db7bf08).
Now that coreos-installer in rawhide has
coreos/coreos-installer#1422 we can set sysroot.bootprefix to true again.
We can't do it in the non-OSBuild configs because not all streams have the new coreos-installer yet.
Here is the comment from the original commit:
This setting will make it so that BLS config entries get prepended with /boot. OSTree already places a boot -> . symlink in the root of the boot filesystem prepending with /boot will always just work.
For context see osbuild/osbuild#1566 (comment)
This also allows for dropping one of the upstream OSBuild zipl stage patches.