Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd-osbuild: fix format for disk image passed to qemu #3943

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

dustymabe
Copy link
Member

Should have been qcow2 and not qcow.

Fixes 5509a8b

Should have been qcow2 and not qcow.

Fixes 5509a8b
Copy link
Member

@marmijo marmijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe
Copy link
Member Author

The CI failure here is an instance of the coreos/fedora-coreos-tracker#1796 flake.

Merging this.

@dustymabe dustymabe merged commit 765d613 into coreos:main Nov 14, 2024
4 of 5 checks passed
@dustymabe dustymabe deleted the dusty-osbuild-fixup branch November 14, 2024 17:26
dustymabe added a commit to dustymabe/custom-coreos-disk-images that referenced this pull request Nov 18, 2024
There was a pretty large refactor tha landed in COSA in
coreos/coreos-assembler#3943
Let's pick up those changes here and change the way we call
runvm-osbuild to adapt.
jlebon pushed a commit to coreos/custom-coreos-disk-images that referenced this pull request Nov 18, 2024
There was a pretty large refactor tha landed in COSA in
coreos/coreos-assembler#3943
Let's pick up those changes here and change the way we call
runvm-osbuild to adapt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants