osbuild: rename build pipeline; use better variable names #3946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jlebon - we discussed naming of this. Just want to take your temperature on the proposal here. |
jlebon
reviewed
Nov 18, 2024
| @@ -32,7 +32,7 @@ mpp-vars: | |||
| # the host (COSA) gets used as the buildroot there. | |||
| buildroot: | |||
| mpp-if: osname in ['rhcos', 'scos'] | |||
| then: "name:build" | |||
| then: "name:plain-files-tree" | |||
There was a problem hiding this comment.
Hmm, I don't quite understand the plain-files-tree naming TBH. :)
I think the thing to emphasize is that the tree represents a "deployed" OSTree? How about deployment-root? Or e.g. deployed-tree? Or deployed-ostree?
There was a problem hiding this comment.
updated to use deployed-tree
We're using it as more than just a buildroot now. We're more just using it as a way to inspect and copy from or load configuration from in various places because the files are laid out in a plain directory structure as it would be in an OSTree deployment. Let's rename it to more appropriately reflect what it is, which might explain why we use it in various places.
It's now used for more than just the qemu stages so let's rename it to be slightly more appropriate.
This makes it a little more explicit.
dustymabe
force-pushed
the
dusty-buildroot-musical-chairs
branch
from
48b168a to
133421e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages.