Dockerfile: don't delete /go #3957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're creating `/go` and then deleting it later on, which doesn't make sense. Stop deleting it to fix the use case of Prow using the cosa image as a buildroot.
jlebon
added a commit
to jlebon/release
that referenced
this pull request
Nov 20, 2024
Effectively carry coreos/coreos-assembler#3957 until it lands and cosa gets rebuilt.
jlebon
added a commit
to jlebon/release
that referenced
this pull request
Nov 20, 2024
Effectively carry coreos/coreos-assembler#3957 until it lands and cosa gets rebuilt.
|
hmm. does it get populated with a bunch of stuff that we don't need to ship, though? |
|
No, it's empty. It's created higher up in the Dockerfile. |
yeah though it's not super clear that none of the steps in between when it is created and the end of the Dockerfile store things in so this PR looks great, but would prefer if we moved the mkdir to below those lines. |
dustymabe
approved these changes
Nov 20, 2024
|
Follow-up in #3958 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're creating
/goand then deleting it later on, which doesn't make sense. Stop deleting it to fix the use case of Prow using the cosa image as a buildroot.