Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty out deps-ppc64le.txt #3978

Merged
merged 1 commit into from
Nov 28, 2024
Merged

empty out deps-ppc64le.txt #3978

merged 1 commit into from
Nov 28, 2024

Conversation

dustymabe
Copy link
Member

It was emptied out and just a comment left in dc22a02 but the way src/print-dependencies.sh works it fails if the grep to remove comments yields nothing. Let's just empty the file for now so the if -s check won't succeed.

@dustymabe
Copy link
Member Author

rhcos CI is failing because it's pulling building off f41 but COSA is still (for now) based on F40??

@dustymabe
Copy link
Member Author

added a commit that I think will make it work even for f41

Copy link

openshift-ci bot commented Nov 28, 2024

@dustymabe: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhcos 626c2a5 link true /test rhcos
ci/prow/images 626c2a5 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dustymabe
Copy link
Member Author

ok nope.. I guess we'll have to get #3975 and then merge this too.

It was emptied out and just a comment left in dc22a02
but the way src/print-dependencies.sh works it fails
if the grep to remove comments yields nothing. Let's
just empty the file for now so the `if -s` check won't
succeed.
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlebon jlebon enabled auto-merge (rebase) November 28, 2024 14:15
@jlebon
Copy link
Member

jlebon commented Nov 28, 2024

CI isn't going to test this, so let's just get it in.

@jlebon jlebon disabled auto-merge November 28, 2024 14:15
@jlebon jlebon merged commit 3347c8b into coreos:main Nov 28, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants