Pre release 0.21.0 #1426
Merged
Pre release 0.21.0 #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
reviewed
Feb 22, 2024
prestist
force-pushed
the
pre-release-0.21.0
branch
from
1adeba2 to
fa9cfba
Compare
prestist
force-pushed
the
pre-release-0.21.0
branch
from
fa9cfba to
8e1812a
Compare
|
Working on working around clap; need to specify a version so we dont need to bump our msrv again. |
prestist
force-pushed
the
pre-release-0.21.0
branch
from
8e1812a to
105deab
Compare
|
Ok I think I have fixed clap now; Will merge once CI passes |
|
I don't really understand one of the commits from this PR: The commit message is "update dependencies", but the commit does not update dependencies, it restricts the versions of clap that can be used. This now broke the package because we updated clap from version 4.4 to 4.5. |
jlebon
added a commit
to jlebon/coreos-installer
that referenced
this pull request
Apr 16, 2024
This reverts the `Cargo.toml` part of ee82223 ("cargo: update dependencies") which limited the clap version to 4.4. But we should be fine to pull in a newer version now that we bumped our MSRV. See also: coreos#1426 (comment) See also: https://src.fedoraproject.org/rpms/rust-coreos-installer/pull-request/65
jlebon
added a commit
to jlebon/coreos-installer
that referenced
this pull request
Apr 16, 2024
This reverts the `Cargo.toml` part of ee82223 ("cargo: update dependencies") which limited the clap version to 4.4. But we should be fine to pull in a newer version now that we bumped our MSRV. See also: coreos#1426 (comment) See also: https://src.fedoraproject.org/rpms/rust-coreos-installer/pull-request/65
|
@decathorpe Thanks. Follow-up in #1453. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1425