Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update commands for matrix bot #61

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Update commands for matrix bot #61

merged 3 commits into from
Jan 24, 2024

Conversation

prestist
Copy link
Contributor

No description provided.

@prestist
Copy link
Contributor Author

This is still a WIP and there are other parts I need to update. Not final.

But this should resolve issues found
#60
#48
#50

@dustymabe
Copy link
Member

let me know when you are ready for review on this!

@prestist
Copy link
Contributor Author

re: #60
"the fcosmeetinghtml() should get updated to accept the new meeting html from the matrix bot. It kind of works right now but doesn't properly hyperlink things in the discussion forum post."

Looking at the existing structure of the logs, I think we might have lost some functionality moving to matrix. I may be mistaken but in the past we had access to an actual link, now we just get timestamps and user names.

I am not sure, but I might be able to cobble something together.

@prestist prestist force-pushed the update-commands branch 3 times, most recently from 9b0477f to b0fcead Compare January 22, 2024 21:49
@prestist prestist marked this pull request as ready for review January 22, 2024 21:49
@prestist
Copy link
Contributor Author

@dustymabe I think its getting there, let me know if you see anything I might have missed

dustymabe
dustymabe reviewed Jan 23, 2024
View reviewed changes
static/meeting-template.md Outdated
@@ -2,7 +2,7 @@

## Meeting Notes

The meeting is held every week, meetings are at `16:30 UTC` on Wednesdays. The meeting is held in #fedora-meeting-1 on libera.chat. The meeting is logged and the logs are available [here](https://meetbot.fedoraproject.org/teams/fedora_coreos_meeting/)
The meeting is held every week, meetings are at `16:30 UTC` on Wednesdays. The meeting is held in [#meeting-1:fedoraproject.org](https://matrix.to/#/#meeting-1:fedoraproject.org) on matrix. The meeting is logged and the logs are available [here](https://meetbot.fedoraproject.org/teams/fedora_coreos_meeting/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here we can just put the full link and the matrix client will actually make it pretty for us (i.e. we don't need to do markdown for the link).

dustymabe
dustymabe reviewed Jan 23, 2024
View reviewed changes
static/meeting-template.md Outdated
Comment on lines 125 to 126
SUMMARY_URL="$1"
LOG_URL="$2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try here to just accept a single URL and then have the function figure out everything it needs from there. The user having to manually stitch together URLs isn't ideal when we can have the computer do it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% agree, was getting burned out on working on the function, will circle back

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok its not pretty but gave it a swing.

dustymabe
dustymabe reviewed Jan 23, 2024
View reviewed changes
static/meeting-template.md Outdated
sed "s|href='fedora|href='${baseurl}/fedora|" | \
sed "s|href=\"fedora|href=\"${baseurl}/fedora|"
}
fcosmeetinghtml() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I tried this function and copied the output into a forum post I managed to get a lot of extra HTML at the beginning and end, did you see that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I did not get around to pasting it in a forum post, I will take a look.

Copy link
Contributor Author

@prestist prestist Jan 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I did not see that.


<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<!--from OG meetbot will change and cleanup-->
<html>
<body>
    <h1>#meeting-1:fedoraproject.org: fedora_coreos_meeting</h1>
<a href="https://meetbot-raw.fedoraproject.org/meeting-1_matrix_fedoraproject-org/2024-01-10/fedora-coreos-meeting.2024-01-10-16.35.log.html#l-1">    <span class="details">Meeting started by @spresti:fedora.im at 16:35:03 UTC</span></a>
    <br><br>
    <h3>Meeting summary</h3>
    <ol>
<a href="https://meetbot-raw.fedoraproject.org/meeting-1_matrix_fedoraproject-org/2024-01-10/fedora-coreos-meeting.2024-01-10-16.35.log.html#l-4">                    <li><b></b><b class="TOPIC">roll call</b> <span class="details">(@spresti:fedora.im, 16:35:16)</span></a></li>
                    <ol type="a">
<a href="https://meetbot-raw.fedoraproject.org/meeting-1_matrix_fedoraproject-org/2024-01-10/fedora-coreos-meeting.2024-01-10-16.35.log.html#l-24"></ol>                    <li><b></b><b class="TOPIC">Action items from last meeting</b> <span class="details">(@spresti:fedora.im, 16:38:59)</span></a></li>
                    <ol type="a">
<a href="https://meetbot-raw.fedoraproject.org/meeting-1_matrix_fedoraproject-org/2024-01-10/fedora-coreos-meeting.2024-01-10-16.35.log.html#l-27"></ol>                    <li><b></b><b class="TOPIC">there are no action items from the last meeting.</b> <span class="details">(@spresti:fedora.im, 16:40:16)</span></a></li>
                    <ol type="a">
<a href="https://meetbot-raw.fedoraproject.org/meeting-1_matrix_fedoraproject-org/2024-01-10/fedora-coreos-meeting.2024-01-10-16.35.log.html#l-30"></ol>                    <li><b></b><b class="TOPIC">New Package Request: mtr</b> <span class="details">(@spresti:fedora.im, 16:41:06)</span></a></li>
                    <ol type="a">
                <li>LINK: https://github.com/coreos/fedora-coreos-tracker/issues/1644 (@spresti:fedora.im, 16:41:17)</li>
                <li>AGREED: the basic functionality of mtr already exists in FCOS through tracepath. Additionally mtr can be installed and ran in a toolbox container. So we currently do not see the need to add this package to the base for everyone. (@spresti:fedora.im, 16:53:51)</li>
<a href="https://meetbot-raw.fedoraproject.org/meeting-1_matrix_fedoraproject-org/2024-01-10/fedora-coreos-meeting.2024-01-10-16.35.log.html#l-58"></ol>                    <li><b></b><b class="TOPIC">aarch64 failing to upgrade with /boot filesystem full</b> <span class="details">(@spresti:fedora.im, 16:54:22)</span></a></li>
                    <ol type="a">
                <li>LINK: https://github.com/coreos/fedora-coreos-tracker/issues/1637 (@spresti:fedora.im, 16:54:34)</li>
                <li>AGREED: continue with the proposed mitigation/fix for this is in https://github.com/coreos/fedora-coreos-tracker/issues/1637#issuecomment-1878186381 which we are actively executing. (@spresti:fedora.im, 17:00:27)</li>
<a href="https://meetbot-raw.fedoraproject.org/meeting-1_matrix_fedoraproject-org/2024-01-10/fedora-coreos-meeting.2024-01-10-16.35.log.html#l-67"></ol>                    <li><b></b><b class="TOPIC">tracker: Fedora 40 changes considerations</b> <span class="details">(@spresti:fedora.im, 17:00:55)</span></a></li>
                    <ol type="a">
                <li>LINK: https://github.com/coreos/fedora-coreos-tracker/issues/1626 (@spresti:fedora.im, 17:01:11)</li>
<a href="https://meetbot-raw.fedoraproject.org/meeting-1_matrix_fedoraproject-org/2024-01-10/fedora-coreos-meeting.2024-01-10-16.35.log.html#l-79"></ol>                    <li><b></b><b class="TOPIC">Open Floor</b> <span class="details">(@spresti:fedora.im, 17:06:53)</span></a></li>
                    <ol type="a">
            </ol>
    </ol>
    <br/>
    <br/>
<a href="https://meetbot-raw.fedoraproject.org/meeting-1_matrix_fedoraproject-org/2024-01-10/fedora-coreos-meeting.2024-01-10-16.35.log.html#l-99">    <span class="details">Meeting ended at 17:19:10 UTC</span></a>
    <br/>
    <br/>



<h3>Action items</h3>
<ol>
    <li>(none)</li>
</ol>
<br><br>



<h3>People present (lines said)</h3>
<ol>
<li>@spresti:fedora.im (42)</li>
<li>@siosm:matrix.org (21)</li>
<li>@dustymabe:matrix.org (18)</li>
<li>@zodbot:fedora.im (7)</li>
<li>@fifofonix:matrix.org (4)</li>
<li>@jlebon:fedora.im (4)</li>
<li>@meetbot:fedora.im (2)</li>
<li>@marmijo:fedora.im (1)</li>
</ol>
<br><br>



</body></html>%

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whats up with the '%' but otherwise looks good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting markdown in github is removing the links, They are there...

dustymabe
dustymabe reviewed Jan 23, 2024
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @prestist for working on this! Added some comments

@prestist
update meeting commands to be reflective of new zodbot
382c2cd 
With the new matrix bot, there are a few changes to the commands.
For the most part the '#' has been replaced with '!'.
dustymabe
dustymabe reviewed Jan 23, 2024
View reviewed changes
static/meeting-template.md
@@ -67,13 +67,11 @@ At least 5 people must vote, or 51% of the WG membership, whichever is less. Vot
If you don't want to be pinged remove your name from this file: https://github.com/coreos/fedora-coreos-tracker/blob/main/issue_template/meeting-template.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the line above needs to say:

FCOS community meeting in https://matrix.to/#/#meeting-1:fedoraproject.org

@dustymabe
Copy link
Member

I'm still getting a lot of extra output.. here is what I am doing:

fcosmeetinghtml https://meetbot.fedoraproject.org/meeting-1_matrix_fedoraproject-org/2024-01-17/fedora-coreos-meeting.2024-01-17-16.29.html

Then copying that into a forum post.

@prestist
Copy link
Contributor Author

Then copying that into a forum post.

hmm, I wonder if there is something system based which is causing that. Do you have something in your .rc file?

Try naming the function something else and seeing if there is less output?

@prestist prestist force-pushed the update-commands branch 2 times, most recently from 95a47d4 to ccd27ad Compare January 24, 2024 15:33
@prestist
actionItems: Update action for new file structure
321b991 
With the change over from IRC bot to matrix bot there seems to be
a small structural change in how the logs are hosted.

You can see the following examples
new https://meetbot-raw.fedoraproject.org/meeting-1_matrix_fedoraproject-org/
vs
old https://meetbot-raw.fedoraproject.org/teams/fedora_coreos_meeting/
@prestist
meeting-template: update fcosmeetinghtml
7040dda 
The latest version of the fcos meetbot does not include links in the html
summary. To keep this feature lets use timestamps as IDs and hydrate them
with links pointing to the log.html.
dustymabe
dustymabe approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - what we have is an improvement and we'll continue to tweak it as we go

@prestist prestist merged commit 4133189 into coreos:main Jan 24, 2024
2 checks passed
@prestist prestist mentioned this pull request Feb 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustymabe dustymabe dustymabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestist @dustymabe