Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meeting-template: Add rollCall function #83

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

prestist
Copy link
Contributor

Fixes #77

@prestist
Copy link
Contributor Author

prestist#24 is what this code results into.

@prestist prestist requested a review from dustymabe April 17, 2024 21:06
src/rollCall.ts Outdated Show resolved Hide resolved
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. No showstoppers. A few questions

dist/index.js Outdated Show resolved Hide resolved
src/rollCall.ts Outdated Show resolved Hide resolved
src/rollCall.ts Outdated Show resolved Hide resolved
static/meeting-template.md Outdated Show resolved Hide resolved
@prestist prestist force-pushed the fetch-names branch 3 times, most recently from 7ba731c to b1290a6 Compare April 18, 2024 13:08
dustymabe added a commit to dustymabe/fedora-coreos-tracker that referenced this pull request Apr 18, 2024
We are automating this now with
coreos/fcos-meeting-action#83
so we have no need for the instructions.
jlebon pushed a commit to coreos/fedora-coreos-tracker that referenced this pull request Apr 18, 2024
We are automating this now with
coreos/fcos-meeting-action#83
so we have no need for the instructions.
@prestist prestist force-pushed the fetch-names branch 5 times, most recently from a13ce06 to 61a59e6 Compare April 18, 2024 16:07
@prestist
Copy link
Contributor Author

prestist commented Apr 18, 2024

Ok, so this should work, my only concern is there is no auto wrapping in a code block, but I suspect it should be fine in matrix

prestist#35

Edit: confirmed, it looks nice in matrix

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prestist prestist merged commit dba3735 into coreos:main Apr 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The meeting template should pull the people list from the tracker repo
2 participants