Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable] tree: promote changes from testing at 0d7d22fb781f5a42ba98f4947b54efe1c39beef7 #2675

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

coreosbot-releng
Copy link

@coreosbot-releng coreosbot-releng commented Oct 16, 2023

marmijo
marmijo previously approved these changes Oct 16, 2023
Copy link
Member

@marmijo marmijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marmijo marmijo self-requested a review October 16, 2023 20:27
@marmijo marmijo dismissed their stale review October 16, 2023 20:27

An update is needed to resolve some conflicting files

@jlebon
Copy link
Member

jlebon commented Oct 16, 2023

I'm not sure, but I think the peter-evans/create-pull-request action got confused by the promotion and revert of the promotion in #2664 and thought that it didn't have to update stable-promotion branch to the latest stable base. This bit of the GHA logs looks suspicious:

2023-10-16T21:05:14.2931610Z [command]/usr/bin/git rev-list --left-only --count fork/stable-promotion...stable-promotion
2023-10-16T21:05:14.2967312Z 0
2023-10-16T21:05:14.2972648Z Branch 'stable-promotion' is even with its remote and will not be updated

So I manually updated this PR for now. I think one way to fix this is to force-push to the fork's branch before calling out to the create-pull-request Action.

@marmijo
Copy link
Member

marmijo commented Oct 16, 2023

Thank you @jlebon!

Copy link
Member

@marmijo marmijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marmijo marmijo merged commit 7b3ec77 into coreos:stable Oct 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants