Avoid fixing labels while deploying new updates #3215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 2e355fd we added a coreos-fix-selinux-labels.service to fix labels on some known files that were unlabeled or mislabeled. We've seen some upgrade tests where the labeling fixes were running at the same time new deployments were getting written into the OSTree repo: ``` Oct 22 11:16:18.923371 kola-runext.service[5408]: Rebasing to fedora-compose:fedora/x86_64/coreos/next Oct 22 11:16:18.926185 kola-runext.service[5408]: Resolving version '41.20241020.1.0' Oct 22 11:16:20.877155 rpm-ostreed.service[1053]: Writing objects: 1 Oct 22 11:16:20.914326 rpm-ostreed.service[1053]: libostree pull from 'fedora-compose' for fedora/x86_64/coreos/next complete security: GPG: commit security: SIGN: disabled http: TLS non-delta: meta: 2 content: 0 transfer: secs: 1 size: 19.0\u00a0kB Oct 22 11:16:20.968177 kola-runext.service[5408]: 2 metadata, 0 content objects fetched; 18 KiB transferred in 1 seconds; 0 bytes content written Oct 22 11:16:20.972130 kola-runext.service[5408]: Writing objects: 1...done Oct 22 11:16:31.630763 coreos-fix-selinux-labels.service[1019]: Relabeled 5582 files to system_u:object_r:root_t:s0 ``` Let's try to avoid writing into the OSTree repo and fixing labels at the same time.
jlebon
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2e355fd we added a coreos-fix-selinux-labels.service to fix labels on some known files that were unlabeled or mislabeled. We've seen some upgrade tests where the labeling fixes were running at the same time new deployments were getting written into the OSTree repo:
Let's try to avoid writing into the OSTree repo and fixing labels at the same time.