-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add temporary workaround for agetty --reload
SELinux denial
#988
Conversation
Still need to test this. |
Once we get this in, we can drop the way hackier workaround in rawhide that was added in #859. |
would dropping a stub ignition config that creates the file work too? I think files that get laid down by ignition get relabeled by default. |
Ignition configs can't write to |
In f34+, we're hitting an SELinux denial from c-l-h-m trying to do `agetty --reload` and causing `/run/agetty.reload` to be created with the wrong label. This then prevents agetty from adding an inotify watch to know when to reload the prompt to display new information. For more details, see: coreos#859 (comment) This is tracked at https://bugzilla.redhat.com/show_bug.cgi?id=1932053. With this workaround, we create the file up front in the initrd so that it gets relabeled by systemd on switchroot and thus will already exists with the right label well before c-l-h-m or anything else tries to `agetty --reload`.
5d8569d
to
316971c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: It would be nice if we bake in some sort of reminder to go back and remove this.
Heh yeah, this is what this comment is about:
(See coreos/fedora-coreos-tracker#704 (comment)). We can bump it to f35 when we're rebasing |
Tested working! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts commit f8b31ab. This is done a cleaner way now in coreos#988.
extensions: use stream9 as builder because of s390x
In f34+, we're hitting an SELinux denial from c-l-h-m trying to do
agetty --reload
and causing/run/agetty.reload
to be created withthe wrong label. This then prevents agetty from adding an inotify watch
to know when to reload the prompt to display new information. For more
details, see:
#859 (comment)
This is tracked at https://bugzilla.redhat.com/show_bug.cgi?id=1932053.
With this workaround, we create the file up front in the initrd so that
it gets relabeled by systemd on switchroot and thus will already exists
with the right label well before c-l-h-m or anything else tries to
agetty --reload
.