Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Major Changes page #371

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Add Major Changes page #371

merged 1 commit into from
Feb 25, 2022

Conversation

travier
Copy link
Member

@travier travier commented Feb 24, 2022 •
edited
Loading

Add new page to store documentation for major changes happening in
Fedora CoreOS.

Fixes #314.

@travier travier force-pushed the major branch 4 times, most recently from 95e604b to 2f58cc2 Compare February 24, 2022 16:33
@travier travier requested review from dustymabe and jlebon February 24, 2022 16:34
@travier
Copy link
Member Author

travier commented Feb 24, 2022

For coreos/fedora-coreos-tracker#1106 & coreos/fedora-coreos-tracker#676

cgwalters
cgwalters approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me so far, thank you so much for doing this!

modules/ROOT/pages/major-changes.adoc Outdated Show resolved Hide resolved
dustymabe
dustymabe approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you @travier

@bgilbert
Copy link
Contributor

Fixes #314.

@bgilbert bgilbert linked an issue Feb 24, 2022 that may be closed by this pull request
Add a breaking changes dashboard #314
Closed
jlebon
jlebon approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, but LGTM overall! Thanks for writing this!

modules/ROOT/pages/major-changes.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/major-changes.adoc Show resolved Hide resolved
modules/ROOT/pages/major-changes.adoc Outdated Show resolved Hide resolved
bgilbert
bgilbert approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

modules/ROOT/pages/major-changes.adoc Outdated Show resolved Hide resolved
@travier travier mentioned this pull request Feb 25, 2022
Merged
@travier
Copy link
Member Author

travier commented Feb 25, 2022 •
edited
Loading

Thanks for the reviews. Latest update should resolve all comments.

@travier travier force-pushed the major branch 2 times, most recently from 22c205f to 3a6bba6 Compare February 25, 2022 13:42
@travier
Add Major Changes page
1625f2b 
Add new page to store documentation for major changes happening in
Fedora CoreOS.
jlebon
jlebon approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jlebon jlebon merged commit ecd5d4d into coreos:main Feb 25, 2022
@travier travier deleted the major branch February 28, 2022 15:40
@travier travier mentioned this pull request Mar 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlebon jlebon jlebon approved these changes

@dustymabe dustymabe dustymabe approved these changes

@bgilbert bgilbert bgilbert approved these changes

@cgwalters cgwalters cgwalters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a breaking changes dashboard
5 participants
@travier @bgilbert @cgwalters @dustymabe @jlebon