Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorial with more details #623

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

yasminvalim
Copy link
Contributor

@yasminvalim yasminvalim commented Apr 3, 2024

During the Fedora 40 test day, while testing the FCOS tutorials, I noticed that it could be a little bit more clear about required ssh file. I've included more details in the note to make it more visible in the related tutorials. This update aims to make the tutorials more beginner-friendly.

BEFORE
image
AFTER
image

@yasminvalim yasminvalim changed the title Enhanced tutorial with more details Update tutorial with more details Apr 3, 2024
@dustymabe
Copy link
Member

I feel like the existing step in the tutorial pre-requisites should cover this?

https://docs.fedoraproject.org/en-US/fedora-coreos/tutorial-setup/#_ssh_public_key

@yasminvalim
Copy link
Contributor Author

yasminvalim commented Apr 3, 2024

I feel like the existing step in the tutorial pre-requisites should cover this?

https://docs.fedoraproject.org/en-US/fedora-coreos/tutorial-setup/#_ssh_public_key

That's true! I will change it and just add a note about it with the link for the pre requisites page. WDYT?

@dustymabe
Copy link
Member

I will change it and just add a note about it with the link for the pre requisites page. WDYT?

Maybe that would help.. can you update the PR here with the suggestion and we can evaluate then?

@yasminvalim yasminvalim force-pushed the improve-tutorial-fcos branch from f00d2f9 to b5f4d80 Compare April 4, 2024 14:44
@yasminvalim yasminvalim self-assigned this Apr 4, 2024
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. The only change I would make is adding tick marks around the ssh-key.pub to make it stand out.

`ssh-key.pub`

@yasminvalim yasminvalim force-pushed the improve-tutorial-fcos branch from b5f4d80 to f6826df Compare April 5, 2024 15:32
@yasminvalim yasminvalim merged commit 24d791e into coreos:main Apr 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants