internal/exec: delete enablement symlinks when disabling unit #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
reviewed
Apr 26, 2022
Yeah, I was thinking about writing an external kola test, however, the blackbox test makes more sense here. |
Merged
sohankunkerkar
force-pushed
the
remove-symlink
branch
from
cf5e0af to
5ced5db
Compare
jlebon
reviewed
Apr 28, 2022
sohankunkerkar
force-pushed
the
remove-symlink
branch
4 times, most recently
from
d54bda3 to
4aa6d50
Compare
jlebon
reviewed
May 3, 2022
sohankunkerkar
force-pushed
the
remove-symlink
branch
from
4aa6d50 to
4fae855
Compare
Done! |
sohankunkerkar
force-pushed
the
remove-symlink
branch
2 times, most recently
from
7f2d394 to
0f12c38
Compare
jlebon
approved these changes
May 4, 2022
sohankunkerkar
force-pushed
the
remove-symlink
branch
from
0f12c38 to
33b2f78
Compare
I don't think we're adding any changes to this folder |
|
Primarily, there're two commits bc this patch affects two folders i.e. |
sohankunkerkar
force-pushed
the
remove-symlink
branch
from
33b2f78 to
ed0c1ab
Compare
bgilbert
changed the title
bgilbert
reviewed
May 6, 2022
sohankunkerkar
force-pushed
the
remove-symlink
branch
4 times, most recently
from
a38cc75 to
8585c47
Compare
For services where FCOS ships a symlink in /etc, if the user tries to disable the service via Ignition, systemd ignores the disablement directive in the preset. Avoid this behavior by deleting the enablement symlinks when disabling a unit, but continue to record the disablement in the preset file. This is a short-term solution until the upstream systemd PR (systemd/systemd#15205) is merged and widely deployed. Fixes coreos/fedora-coreos-tracker#392
sohankunkerkar
force-pushed
the
remove-symlink
branch
from
8585c47 to
397aa6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to delete any enablement symlinks for a unit before sending it to a preset directive. This will help to disable that unit completely. This is a short-term solution until the upstream systemd PR (systemd/systemd#15205) gets accepted.
Fixes coreos/fedora-coreos-tracker#392