Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: also ignore kernel-debug-modules.posttrans #4526

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

jmarrero
Copy link
Member

@jmarrero jmarrero commented Aug 4, 2023

This should solve:

Aug 04 12:01:34 cosa-devsh rpm-ostree(kernel-debug-modules.posttrans)[4302]: dracut: No '/dev/log' or 'logger' included for syslog logging
Aug 04 12:01:35 cosa-devsh rpm-ostree(kernel-debug-modules.posttrans)[4302]: dracut: Can't write to /boot: Directory /boot does not exist or is not accessible.

@jmarrero
Copy link
Member Author

jmarrero commented Aug 4, 2023

Maybe we should ignore all kernel post trans at some point...

@jmarrero jmarrero requested a review from cgwalters August 4, 2023 12:31
@cgwalters
Copy link
Member

It looks like a modules.posttrans was introduced in https://src.fedoraproject.org/rpms/kernel/c/dab93b00b0acac32ebed02f8f177ad5bccc9997a

@@ -23,6 +23,7 @@ static IGNORED_PKG_SCRIPTS: phf::Set<&'static str> = phf_set! {
"kernel-core.posttrans",
"kernel-redhat-core.posttrans",
"kernel-debug-core.posttrans",
"kernel-debug-modules.posttrans",
"kernel-redhat-debug-core.posttrans",
"kernel-automotive-core.posttrans",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g. I think we should likely ignore kernel-automotive-modules.posttrans too

Copy link
Member Author

@jmarrero jmarrero Aug 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed an update ignoring *-modules.posttrans", for all variants.

@cgwalters cgwalters enabled auto-merge (rebase) August 4, 2023 16:42
@cgwalters cgwalters merged commit eae7e1d into coreos:main Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants