Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CTX-5783: Mypy Linter Action #171

Merged
merged 38 commits into from
Aug 20, 2024
Merged

CTX-5783: Mypy Linter Action #171

merged 38 commits into from
Aug 20, 2024

Conversation

VukManojlovic
Copy link
Collaborator

No description provided.

@dule1322 dule1322 marked this pull request as draft July 2, 2024 11:19
@dule1322 dule1322 assigned bogdant36 and dule1322 and unassigned bogdant36 Jul 2, 2024
@dule1322 dule1322 requested a review from bogdant36 July 2, 2024 12:47
@VukManojlovic VukManojlovic changed the title CTX-5783: Mypy errors fixed CTX-5783: Mypy Linter Action Jul 5, 2024
@VukManojlovic VukManojlovic marked this pull request as ready for review July 18, 2024 09:11
dule1322
dule1322 requested changes Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@dule1322 dule1322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check which libraries added to mypy config file have types and remove them from there?

tasks/annotated-image-extractor/.mypy.ini Outdated Show resolved Hide resolved
tasks/bio-bodysite-prediction-nn/src/model.py Outdated Show resolved Hide resolved
tasks/bio-bodysite-prediction/src/cache_json.py Outdated Show resolved Hide resolved
tasks/bio-bodysite-prediction/src/load_data.py Outdated Show resolved Hide resolved
tasks/bio-bodysite-prediction/task.yaml Outdated Show resolved Hide resolved
tasks/object-detection-yolov10/.mypy.ini Outdated Show resolved Hide resolved
tasks/object-detection-yolov8/.mypy.ini Outdated Show resolved Hide resolved
tasks/ollama-rag-index/.mypy.ini Outdated Show resolved Hide resolved
tasks/translation-ollama/.mypy.ini Outdated Show resolved Hide resolved
tasks/synthetic-image-generator/.mypy.ini Outdated Show resolved Hide resolved
dule1322
dule1322 requested changes Aug 19, 2024
View reviewed changes
tasks/qiime-import/mypy.ini Outdated Show resolved Hide resolved
tasks/bio-read-quality/.mypy.ini Outdated Show resolved Hide resolved
@dule1322 dule1322 merged commit 7410465 into coretex-ai:develop Aug 20, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dule1322 dule1322 dule1322 approved these changes

@bogdant36 bogdant36 Awaiting requested review from bogdant36

Assignees

@dule1322 dule1322

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VukManojlovic @dule1322 @bogdant36