CTX-5485: Changes regarding decision to not use anymore coretex cli tool which was installed via pip. #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 13, 2024 16:01
…d CLI (compiled via pyinstaller) work as CLI installed via pip.
…ool which was installed via pip.
dule1322
requested changes
Aug 16, 2024
cli_entrypoint.py
Outdated
| @@ -70,3 +56,6 @@ def cli() -> None: | |||
| cli.add_command(run) | |||
| cli.add_command(version) | |||
| cli.add_command(update) | |||
|
|
|||
| if getattr(sys, 'frozen', False): | |||
There was a problem hiding this comment.
Add comment explaining why this is needed
…cessing and detecting frozen state is needed.
…stallation package for debian.
dule1322
requested changes
Aug 26, 2024
|
|
||
| # Define package name and directory structure | ||
| PACKAGE_NAME="coretex" | ||
| PACKAGE_DIR="${PACKAGE_NAME}" |
There was a problem hiding this comment.
This should be "dist/SOMETHING_SOMETHING"
.build/compile.sh
Outdated
| source compile_env/bin/activate | ||
|
|
||
| # Install the current package and pyinstaller | ||
| pip install .. toml pyinstaller |
There was a problem hiding this comment.
Why is this installing toml?
| mkdir -p "${BIN_DIR}" | ||
|
|
||
| # Create a Python virtual environment | ||
| python -m venv compile_env |
There was a problem hiding this comment.
Rename the venv to debian-package-venv
.build/macos-package.sh
Outdated
| PAYLOAD_DIR="dist/coretex/" | ||
|
|
||
| # Build the .pkg package using pkgbuild | ||
| pkgbuild --root "${PAYLOAD_DIR}" --identifier ai.coretex --version 1.0 --install-location "/usr/local/bin" "${PACKAGE_NAME}.pkg" |
There was a problem hiding this comment.
Can the version be loaded from the pyproject.toml?
.build/generate_control.py
Outdated
|
|
||
| # Create control file content | ||
| controlContent = (f"Package: {packageName}\n" | ||
| f"Version: {version}\n" |
.build/generate_control.py
Outdated
| # Extract necessary information | ||
| packageName = pyproject['project']['name'] | ||
| version = pyproject['project']['version'] | ||
| description = pyproject['project']['description'] |
|
This will not be merged until the deployment is properly working for this change. |
# Conflicts: # coretex/cli/commands/node.py # coretex/cli/modules/update.py # main.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CTX-5485: Changes regarding decision to not use anymore coretex cli tool which was installed via pip.