Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception when loadHeaderOnly for nifti file with extended header. #19

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Fix exception when loadHeaderOnly for nifti file with extended header. #19

merged 1 commit into from
Aug 18, 2020

Conversation

ladeirarodolfo
Copy link
Collaborator

Includes

  • It enhances nifti-reader-js package to readHeader for header data only (on an extended header nifti file)
  • Ensure voxel orientation order for any (xyz) combination
  • Some lint fixes

@tpenzkofer
Copy link

Hi,

this issue might be relevant to this pull-request: #17, especially ijk->patient space calculations in case of off-plane imaging... wouldn't it be necessary to recalculate the ImageOrigin when transposing/flipping the orientation matrix? any thoughts on that?

@jody-zeitler jody-zeitler merged commit 00ab078 into master Aug 18, 2020
@jody-zeitler jody-zeitler deleted the fix-loadHeaderOnly-exception branch June 16, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jody-zeitler jody-zeitler jody-zeitler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ladeirarodolfo @tpenzkofer @jody-zeitler