add export processor option to profile scraper #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proposal for a feature #5
the main idea here is to add options for Profile scraper with something like middleware handlers that can read raw bytes from profile and make their side effects with it.
So now i'm able to add S3 (or any other) exporter if I use cluster-agent as a module.
We can add few more code to add configurable exporters out of the box. Like if we add connection string to s3 bucket somewhere in a good place - add profile processor and push profile to s3. For those who want to have raw pprof files but don't want to use agent as a module.
It also give ability to show proof url to download profile from coroot ui.
What do you think?