Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/transfer and call #222

Merged
merged 11 commits into from
Nov 8, 2023
Merged

Feature/transfer and call #222

merged 11 commits into from
Nov 8, 2023

Conversation

malteish
Copy link
Collaborator

@malteish malteish commented Nov 7, 2023

closes #131

@malteish malteish changed the base branch from main to develop November 7, 2023 20:17
@malteish malteish marked this pull request as draft November 7, 2023 20:17
Copy link
Collaborator

@CJentzsch CJentzsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems as if we can simplify the code a bit.

contracts/PublicFundraising.sol Show resolved Hide resolved
contracts/PublicFundraising.sol Show resolved Hide resolved
contracts/PublicFundraising.sol Show resolved Hide resolved
@malteish malteish marked this pull request as ready for review November 8, 2023 12:05
CJentzsch
CJentzsch previously approved these changes Nov 8, 2023
contracts/PublicFundraising.sol Show resolved Hide resolved
contracts/PublicFundraising.sol Show resolved Hide resolved
@malteish malteish merged commit bbdaf6f into develop Nov 8, 2023
3 checks passed
@malteish malteish deleted the feature/transferAndCall branch November 8, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use transferAndCall to reduce the investment in continuousFundraising to 1 transaction
2 participants