Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax requirement for 128 bit totp secrets #358

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Relax requirement for 128 bit totp secrets #358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/pass.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1041,7 +1041,9 @@ impl PasswordEntry {
}
end_pos
};
let totp = TOTP::from_url(&secret[start_pos..end_pos])?;
// Use unchecked for sites like Discord, Github that still use 80
// bit secrets. https://github.com/constantoine/totp-rs/issues/46
let totp = TOTP::from_url_unchecked(&secret[start_pos..end_pos])?;
secret.zeroize();
Ok(totp.generate_current()?)
} else {
Expand Down
Loading