Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support experimental promql functions #6355

Merged

Conversation

SungJin1212
Copy link
Contributor

This PR adds an experimental flag querier.enable-promql-experimental-functions to enable experimental promQL functions to be used.

This PR tests experimental promQL functions except limitk and limit_ratio. These are the sampling aggregator returns subnet of the input samples. So, we should devise another test to verify the compatibility between Cortex and Prometheus.

Which issue(s) this PR fixes:
Fixes #6307

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@SungJin1212 SungJin1212 force-pushed the Support-experimental-promql-functions branch from 405da88 to 62a556c Compare November 21, 2024 08:43
@SungJin1212 SungJin1212 force-pushed the Support-experimental-promql-functions branch from 62a556c to 311a30f Compare November 21, 2024 09:23
Copy link
Member

@alanprot alanprot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

LGTM.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 21, 2024
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yeya24 yeya24 merged commit 0dc2e33 into cortexproject:master Nov 22, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/querier lgtm This PR has been approved by a maintainer size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support experimental promql functions
3 participants