Support persistent volumes in Cosmos chains #255
Conversation
| @@ -2,6 +2,8 @@ chains: | |||
| - name: osmosis-1 | |||
| type: osmosis | |||
| numValidators: 1 | |||
| storageClassName: standard-rwo | |||
| storage: 1Gi | |||
There was a problem hiding this comment.
could we update this to
storage:
className: standard-rwo
size: 1GiMight make more sense for the users. I would like to avoid exposing all the k8s specific naming directly to the users (if it can be avoided and made simpler).
There was a problem hiding this comment.
I imagine that this is mostly needed for production use case. At least, that's when we use it. With this assumption, I believe that a Starship user knows what they are doing and familiar with k8s concepts and hence they want to have better controls. Otherwise, Starship needs to expose the same concepts but with Starship alternatives. That doesn't sounds like a good UX to me.
If you have better ideas at how to allow fine controls, let me know.
There was a problem hiding this comment.
Makes sense, we dont have to change the names, but if we could still move it into storage, it will make the happy path to be less cluttered.
| {{- if hasKey $chain "storage" }} | ||
| - name: init-chmod-data | ||
| image: busybox | ||
| command: ['sh', '-c', 'chmod -R 0777 {{ $chain.home }}'] |
There was a problem hiding this comment.
hmm maybe there is another way to do this. Will have to look into this.
There was a problem hiding this comment.
I think it depends on what user runs the containers. If you know a better way, I would gladly implement it.
|
@Inkvi could we maybe move the same directives inside something like 'storage', we can still keep the names same. The idea is to be able to make helm charts more modular, a flat hierarchy will get confusing to expand. Helm charts usually also do this, have a look at 'persistence' directive in this chart: https://github.com/bitnami/charts/blob/main/bitnami/cassandra/values.yaml Also for flags, the norm is to use '.enabled: true'. |
|
I can take care of it too, as part of beautification of the helm charts itself as well, if you want. We can merge this as a feature, and then i can update it, but just wanted to let you know how i am thinking of this. |
No description provided.