Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove pods from checking status, if they are no longer found, update default chart version #570

Merged
merged 1 commit into from
Oct 18, 2024
Merged

fix: remove pods from checking status, if they are no longer found, update default chart version #570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions clients/js/packages/client/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export interface PodPorts {
}

const defaultName: string = 'starship';
const defaultVersion: string = 'v0.2.14';
const defaultVersion: string = 'v0.2.19';

// TODO talk to Anmol about moving these into yaml, if not already possible?
const defaultPorts: PodPorts = {
Expand Down Expand Up @@ -558,6 +558,13 @@ export class StarshipClient implements StarshipClientI {
public async waitForPods(): Promise<void> {
const podNames = this.getPodNames();

// Remove pods that are no longer active from the podStatuses map
this.podStatuses.forEach((_value, podName) => {
if (!podNames.includes(podName)) {
this.podStatuses.delete(podName);
}
});

// Check the status of each pod retrieved
podNames.forEach((podName) => {
this.checkPodStatus(podName);
Expand Down Expand Up @@ -658,7 +665,6 @@ export class StarshipClient implements StarshipClientI {
const eventLines = eventsSection
.split('\n')
.filter((line) => line.trim() !== '');
this.log(`event lints: ${eventLines.join('\n')}`);

return eventLines;
}
Expand Down