feat(timeout-height): expectAsync fail test

cosmos · Oct 26, 2023 · af78d54 · af78d54
1 parent 5bdd121
commit af78d54
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 36 deletions.
diff --git a/packages/cosmwasm-stargate/src/signingcosmwasmclient.spec.ts b/packages/cosmwasm-stargate/src/signingcosmwasmclient.spec.ts
@@ -1247,16 +1247,15 @@ describe("SigningCosmWasmClient", () => {
         const height = await client.getHeight();
         const signed = await client.sign(alice.address0, [msgAny], fee, memo, undefined, BigInt(height - 1));
 
-        try {
-          await client.broadcastTx(Uint8Array.from(TxRaw.encode(signed).finish()));
-        } catch (e: any) {
-          assert(e.code === 30);
-          return;
-        } finally {
-          client.disconnect();
-        }
+        await expectAsync(
+          client.broadcastTx(Uint8Array.from(TxRaw.encode(signed).finish())),
+        ).toBeRejectedWith(
+          jasmine.objectContaining({
+            code: 30,
+          }),
+        );
 
-        throw new Error("tx should have failed because of past timeoutHeight");
+        client.disconnect();
       });
     });
 
@@ -1530,16 +1529,15 @@ describe("SigningCosmWasmClient", () => {
         const height = await client.getHeight();
         const signed = await client.sign(alice.address0, [msgAny], fee, memo, undefined, BigInt(height - 1));
 
-        try {
-          await client.broadcastTx(Uint8Array.from(TxRaw.encode(signed).finish()));
-        } catch (e: any) {
-          assert(e.code === 30);
-          return;
-        } finally {
-          client.disconnect();
-        }
+        await expectAsync(
+          client.broadcastTx(Uint8Array.from(TxRaw.encode(signed).finish())),
+        ).toBeRejectedWith(
+          jasmine.objectContaining({
+            code: 30,
+          }),
+        );
 
-        throw new Error("tx should have failed because of past timeoutHeight");
+        client.disconnect();
       });
     });
   });

diff --git a/packages/stargate/src/signingstargateclient.spec.ts b/packages/stargate/src/signingstargateclient.spec.ts
@@ -969,16 +969,15 @@ describe("SigningStargateClient", () => {
         const height = await client.getHeight();
         const signed = await client.sign(faucet.address0, [msgAny], fee, memo, undefined, BigInt(height - 1));
 
-        try {
-          await client.broadcastTx(Uint8Array.from(TxRaw.encode(signed).finish()));
-        } catch (e: any) {
-          assert(e.code === 30);
-          return;
-        } finally {
-          client.disconnect();
-        }
+        await expectAsync(
+          client.broadcastTx(Uint8Array.from(TxRaw.encode(signed).finish())),
+        ).toBeRejectedWith(
+          jasmine.objectContaining({
+            code: 30,
+          }),
+        );
 
-        throw new Error("tx should have failed because of past timeoutHeight");
+        client.disconnect();
       });
     });
 
@@ -1248,16 +1247,15 @@ describe("SigningStargateClient", () => {
         const height = await client.getHeight();
         const signed = await client.sign(faucet.address0, [msgAny], fee, memo, undefined, BigInt(height - 1));
 
-        try {
-          await client.broadcastTx(Uint8Array.from(TxRaw.encode(signed).finish()));
-        } catch (e: any) {
-          assert(e.code === 30);
-          return;
-        } finally {
-          client.disconnect();
-        }
+        await expectAsync(
+          client.broadcastTx(Uint8Array.from(TxRaw.encode(signed).finish())),
+        ).toBeRejectedWith(
+          jasmine.objectContaining({
+            code: 30,
+          }),
+        );
 
-        throw new Error("tx should have failed because of past timeoutHeight");
+        client.disconnect();
       });
     });
   });