Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cosmos-sdk-proto): no_std compatible serde feature #513

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

rnbguy
Copy link
Contributor

@rnbguy rnbguy commented Nov 8, 2024

fix #512

@rnbguy rnbguy changed the title fix(cosmos-sdk-proto): disable default-features for pbjson fix(cosmos-sdk-proto): no_std compatible serde feature Nov 8, 2024
@rnbguy
Copy link
Contributor Author

rnbguy commented Nov 8, 2024

hey @tony-iqlusion it'd be great if a release can be cut quickly for this. This will unblock a dep-update PR at ibc-rs.

@tony-iqlusion
Copy link
Member

These are technically breaking changes, but I don't imagine they'd actually have real-world impacts.

@tony-iqlusion tony-iqlusion merged commit 5f4f3b9 into cosmos:main Nov 8, 2024
11 checks passed
@rnbguy
Copy link
Contributor Author

rnbguy commented Nov 8, 2024

Thanks so much for the quick response and release ! 🚀

Since you talked about breaking changes, I reviewed my changes once again -- and realized that, probably I should have added pbjson/std to the std feature set. I will let you decide on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cosmos-sdk-proto's serde feature is no_std incompatible
2 participants