Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: amend redirect links so that they point to main #33

Merged
merged 19 commits into from
Sep 20, 2023
Merged

Conversation

samricotta
Copy link
Contributor

No description provided.

@samricotta
Copy link
Contributor Author

Need to add in the ones for the landing page as @julienrbrt mentioned in slack

docusaurus.config.js Outdated Show resolved Hide resolved
docusaurus.config.js Outdated Show resolved Hide resolved
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there files being renamed here?

docusaurus.config.js Show resolved Hide resolved
docusaurus.config.js Outdated Show resolved Hide resolved
docusaurus.config.js Outdated Show resolved Hide resolved
docusaurus.config.js Outdated Show resolved Hide resolved
docusaurus.config.js Outdated Show resolved Hide resolved
@samricotta
Copy link
Contributor Author

Need to figure out why all these are breaking after rebase.

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for redirections. but I re-iterate saying that I do not think there should be docs/ and versioned_docs/ changes here.

@samricotta
Copy link
Contributor Author

@julienrbrt do you mean these bits should be in a different PR?

@julienrbrt
Copy link
Member

@julienrbrt do you mean these bits should be in a different PR?

Yea, I do not understand why there are in this PR and how it got added.

@samricotta
Copy link
Contributor Author

The scope of the PR changed but its because the redirects and the links are tightly coupled and shown when running npm run build so it makes sense to fix them all at once

@julienrbrt
Copy link
Member

The scope of the PR changed but its because the redirects and the links are tightly coupled and shown when running npm run build so it makes sense to fix them all at once

Alright 👍🏾

@samricotta samricotta merged commit 4c01022 into main Sep 20, 2023
1 check passed
@samricotta samricotta deleted the sam/redirect branch September 20, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants