Skip to content

Commit

Permalink
chore(client/v2): explain breaking change v0.50 / v0.51 autocli (#17764)
Browse files Browse the repository at this point in the history
  • Loading branch information
julienrbrt authored Sep 15, 2023
1 parent a0bd4e9 commit 9da9a23
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 2 deletions.
13 changes: 12 additions & 1 deletion client/v2/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,15 @@ Ref: https://keepachangelog.com/en/1.0.0/

# Changelog

## [Unreleased]
## [Unreleased]

<!-- ## [v2.1.0-alpha.1] to be tagged after v0.51 final-->

### API Breaking Changes

* [#17709](https://github.com/cosmos/cosmos-sdk/pull/17709) Address codecs have been removed from `autocli.AppOptions` and `flag.Builder`. Instead client/v2 uses the address codecs present in the context (introduced in [#17503](https://github.com/cosmos/cosmos-sdk/pull/17503)).

## [v2.0.0-alpha.1] <!-- to be tagged after tx support and v0.50 final-->

This is the first tagged version of client/v2.
It depends on the Cosmos SDK v0.50 release and fully supports AutoCLI.
2 changes: 1 addition & 1 deletion client/v2/autocli/flag/address.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ func (a addressValue) Type() string {
type consensusAddressStringType struct{}

func (a consensusAddressStringType) NewValue(ctx context.Context, b *Builder) Value {
return &consensusAddressValue{addressValue: addressValue{addressCodec: b.ClientCtx.ConsensusAddressCodec, keyring: b.ClientCtx.Keyring}}
return &consensusAddressValue{addressValue: addressValue{addressCodec: b.ClientCtx.ConsensusAddressCodec, keyring: b.Keyring}}
}

func (a consensusAddressStringType) DefaultValue() string {
Expand Down

0 comments on commit 9da9a23

Please sign in to comment.